From cd2c2991be1f45c297f666e749b0286b43d0737d Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Thu, 29 Jan 2015 15:36:04 +0100 Subject: [PATCH] printing/cups: pack requested-attributes with IPP_TAG_KEYWORD The CUPS IPP_GET_JOBS requested-attributes array indicates which job attributes the caller would like in the cupsd response. Until now, Samba has packed these attributes with a IPP_TAG_NAME format tag. In recent versions of CUPS, this results in the IPP_GET_JOBS response only including the job-id and job-printer-uri fields, even with JobPrivateValues=none configured. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10808 Signed-off-by: David Disseldorp --- source3/printing/print_cups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git source3/printing/print_cups.c source3/printing/print_cups.c index 68f367c..561e07d 100644 --- source3/printing/print_cups.c +++ source3/printing/print_cups.c @@ -1157,7 +1157,7 @@ static int cups_queue_get(const char *sharename, ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE, "attributes-natural-language", NULL, language->language); - ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME, + ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD, "requested-attributes", (sizeof(jattrs) / sizeof(jattrs[0])), NULL, jattrs); -- 2.1.2