From 232abcc93277b8c6235b1656bfcdcbac5688ed48 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 20 Jun 2017 11:20:38 -0700 Subject: [PATCH] s3: smbd: When deleting an fsp pointer ensure we don't keep any references to it around. Based on a suggestion from https://bugzilla.samba.org/show_bug.cgi?id=12818 Signed-off-by: Jeremy Allison Reviewed-by: Richard Sharpe Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Thu Jun 22 00:12:49 CEST 2017 on sn-devel-144 --- source3/smbd/files.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/source3/smbd/files.c b/source3/smbd/files.c index 6d0f05b9db1..303ab7bb926 100644 --- a/source3/smbd/files.c +++ b/source3/smbd/files.c @@ -552,9 +552,7 @@ void file_free(struct smb_request *req, files_struct *fsp) * Clear all possible chained fsp * pointers in the SMB2 request queue. */ - if (req != NULL && req->smb2req) { - remove_smb2_chained_fsp(fsp); - } + remove_smb2_chained_fsp(fsp); /* Drop all remaining extensions. */ vfs_remove_all_fsp_extensions(fsp); -- 2.11.0