From 98812a5f799df544c4b420225c7ed5f6b2fee30c Mon Sep 17 00:00:00 2001 From: Gary Lockyer Date: Tue, 7 May 2019 16:30:22 +1200 Subject: [PATCH] s4 lib socket: Ensure address string owned by parent struct The local address string was not owned by it's parent structure, which caused a use after free error in continue_ip_open_socket source4/librpc/rpc/dcerpc_sock.c:267 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13929 Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed May 8 20:03:42 UTC 2019 on sn-devel-184 (cherry picked from commit ae9fb93393bcadbc71328335e481e4381ecb65bf) --- source4/lib/socket/socket_ip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/lib/socket/socket_ip.c b/source4/lib/socket/socket_ip.c index fd109a3eacd..2aba491e06c 100644 --- a/source4/lib/socket/socket_ip.c +++ b/source4/lib/socket/socket_ip.c @@ -999,7 +999,7 @@ static struct socket_address *ipv6_tcp_get_my_addr(struct socket_context *sock, return NULL; } - local->addr = talloc_strdup(mem_ctx, addrstring); + local->addr = talloc_strdup(local, addrstring); if (!local->addr) { talloc_free(local); return NULL; -- 2.17.1