From c15f0a734ca86bd31c431b57e16b387aeab9285e Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 9 Jun 2021 12:22:26 -0700 Subject: [PATCH] s3: smbd: Remove erroneous TALLOC_FREE(smb_fname_parent) in change_file_owner_to_parent() error path. Caller is still using this ! BUG: https://bugzilla.samba.org/show_bug.cgi?id=14736 Signed-off-by: Jeremy Allison Reviewed-by: Noel Power Autobuild-User(master): Noel Power Autobuild-Date(master): Fri Jun 11 10:17:46 UTC 2021 on sn-devel-184 (cherry picked from commit 4f20d310af2bb1f96dea4810a7130492cc4cfc55) --- source3/smbd/open.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/source3/smbd/open.c b/source3/smbd/open.c index 9a18088c929..b9f5472b765 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -993,7 +993,6 @@ void change_file_owner_to_parent(connection_struct *conn, "directory %s. Error was %s\n", smb_fname_str_dbg(smb_fname_parent), strerror(errno))); - TALLOC_FREE(smb_fname_parent); return; } @@ -1003,7 +1002,6 @@ void change_file_owner_to_parent(connection_struct *conn, "is already owned by uid %d\n", fsp_str_dbg(fsp), (int)fsp->fsp_name->st.st_ex_uid )); - TALLOC_FREE(smb_fname_parent); return; } -- 2.27.0