From 2acdf6fa057c04781d2f8a774446a66b2642a288 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Wed, 31 Aug 2022 12:27:53 +0100 Subject: [PATCH] s3/winbindd: Fix bad access to sid array (with debug level >= info) ==6436== at 0xA85F95B: dom_sid_string_buf (dom_sid.c:444) ==6436== by 0xA85FBF2: dom_sid_str_buf (dom_sid.c:515) ==6436== by 0x17EDF8: wb_lookupusergroups_recv (wb_lookupusergroups.c:115) ==6436== by 0x17F964: wb_gettoken_gotgroups (wb_gettoken.c:123) ==6436== by 0x56AD332: _tevent_req_notify_callback (tevent_req.c:141) ==6436== by 0x56AD493: tevent_req_finish (tevent_req.c:193) ==6436== by 0x56AD5C0: tevent_req_trigger (tevent_req.c:250) ==6436== by 0x56AC119: tevent_common_invoke_immediate_handler (tevent_immediate.c:190) ==6436== by 0x56AC268: tevent_common_loop_immediate (tevent_immediate.c:236) ==6436== by 0x56B678A: epoll_event_loop_once (tevent_epoll.c:919) ==6436== by 0x56B31C3: std_event_loop_once (tevent_standard.c:110) ==6436== by 0x56AA621: _tevent_loop_once (tevent.c:825) ==6436== ==6436== Invalid read of size 1 ==6436== at 0xA85F95B: dom_sid_string_buf (dom_sid.c:444) ==6436== by 0xA85FBF2: dom_sid_str_buf (dom_sid.c:515) ==6436== by 0x17EDF8: wb_lookupusergroups_recv (wb_lookupusergroups.c:115) ==6436== by 0x17F964: wb_gettoken_gotgroups (wb_gettoken.c:123) ==6436== by 0x56AD332: _tevent_req_notify_callback (tevent_req.c:141) ==6436== by 0x56AD493: tevent_req_finish (tevent_req.c:193) ==6436== by 0x56AD5C0: tevent_req_trigger (tevent_req.c:250) ==6436== by 0x56AC119: tevent_common_invoke_immediate_handler (tevent_immediate.c:190) ==6436== by 0x56AC268: tevent_common_loop_immediate (tevent_immediate.c:236) ==6436== by 0x56B678A: epoll_event_loop_once (tevent_epoll.c:919) ==6436== by 0x56B31C3: std_event_loop_once (tevent_standard.c:110) ==6436== by 0x56AA621: _tevent_loop_once (tevent.c:825) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15160 Signed-off-by: Noel Power Reviewed-by: Volker Lendecke Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Wed Aug 31 15:07:31 UTC 2022 on sn-devel-184 (cherry picked from commit 1788b59bc0aaa8f18186ad9b9945fbd634f02445) --- source3/winbindd/wb_lookupusergroups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/winbindd/wb_lookupusergroups.c b/source3/winbindd/wb_lookupusergroups.c index 7ac1b6e03d2..7f359ee9316 100644 --- a/source3/winbindd/wb_lookupusergroups.c +++ b/source3/winbindd/wb_lookupusergroups.c @@ -113,7 +113,7 @@ NTSTATUS wb_lookupusergroups_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx, for (i = 0; i < *num_sids; i++) { struct dom_sid_buf buf; D_INFO("%"PRIu32": %s\n", - i, dom_sid_str_buf(&*sids[i], &buf)); + i, dom_sid_str_buf(&(*sids)[i], &buf)); } } return NT_STATUS_OK; -- 2.35.3