From 1f9bf2b7c446df7fadf9120e34c129b1e8217b17 Mon Sep 17 00:00:00 2001 From: Andreas Hasenack Date: Tue, 15 Apr 2025 17:31:23 -0300 Subject: [PATCH] python:netcmd:gpo: fix crash when listing empty MOTD GPO The motd list command crashes when trying to list an empty MOTD text. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15848 Signed-off-by: Andreas Hasenack --- python/samba/netcmd/gpo.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/samba/netcmd/gpo.py b/python/samba/netcmd/gpo.py index a8e28274c75..ccacf9af972 100644 --- a/python/samba/netcmd/gpo.py +++ b/python/samba/netcmd/gpo.py @@ -3764,7 +3764,9 @@ samba-tool gpo manage motd list {31B2F340-016D-11D2-945F-00C04FB984F9} policy = xml_data.find('policysetting') data = policy.find('data') text = data.find('text') - self.outf.write(text.text) + if text is not None: + if text.text is not None: + self.outf.write(text.text) class cmd_set_motd(GPOCommand): """Sets a VGP MOTD Group Policy to the sysvol -- 2.43.0