From 99ee6b9abc79732f0b8a128d4a36a1f71d9ba94e Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 28 Apr 2012 19:51:46 +0200 Subject: [PATCH] s3: Fix bug 8904 -- wbinfo --lookup-sids "" crashes winbind Much of the code further down and up the call chain expects the structures wb_lookupsids returns to be allocated. Do that despite we have nothing to look up. --- source3/winbindd/wb_lookupsids.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/source3/winbindd/wb_lookupsids.c b/source3/winbindd/wb_lookupsids.c index cdca7c7..2fd735d 100644 --- a/source3/winbindd/wb_lookupsids.c +++ b/source3/winbindd/wb_lookupsids.c @@ -123,11 +123,6 @@ struct tevent_req *wb_lookupsids_send(TALLOC_CTX *mem_ctx, state->sids = sids; state->num_sids = num_sids; - if (num_sids == 0) { - tevent_req_done(req); - return tevent_req_post(req, ev); - } - state->single_sids = TALLOC_ARRAY(state, uint32_t, num_sids); if (tevent_req_nomem(state->single_sids, req)) { return tevent_req_post(req, ev); @@ -153,6 +148,11 @@ struct tevent_req *wb_lookupsids_send(TALLOC_CTX *mem_ctx, return tevent_req_post(req, ev); } + if (num_sids == 0) { + tevent_req_done(req); + return tevent_req_post(req, ev); + } + for (i=0; i