From c0ddfed07a38ee3519741698a8191fabcb37260b Mon Sep 17 00:00:00 2001 From: Matthieu Patou Date: Fri, 1 Jun 2012 15:33:04 -0700 Subject: [PATCH] s3-winbindd: call dump_core_setup after command line option has been parsed The rational behind this is to do like it's done in smbd. Without this fix in some situations winbindd can't coredump. Such cases append when samba is compiled in a custom prefix (ie. /home/build/mat/prod/1/) in this case get_dyn_LOGFILEBASE or basename(lp_logfile) before the configuration file and the command line is parsed it will be something like /home/build/mat/prod/1/var which most probably didn't exists in production. Specifying --log-basename didn't help as dump_core_setup is called before the command line and the config file is read so it didn't help getting a correct value in dump_core_setup. We fix this issue by calling dump_core_setup() also after the configuration has been read, hence giving the opportunity to catch most of the failure. --- source3/winbindd/winbindd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c index 70749c5..5465e31 100644 --- a/source3/winbindd/winbindd.c +++ b/source3/winbindd/winbindd.c @@ -1074,6 +1074,7 @@ int main(int argc, char **argv, char **envp) } } + dump_core_setup("winbindd"); if (is_daemon && interactive) { d_fprintf(stderr,"\nERROR: " "Option -i|--interactive is not allowed together with -D|--daemon\n\n"); -- 1.7.11-rc0