From 022e4ddb7e499e8925d3b3290291372ffc7c5b31 Mon Sep 17 00:00:00 2001 From: Christian Ambach Date: Thu, 30 Aug 2012 16:43:33 +0200 Subject: [PATCH 1/2] s3:libsmb correctly set isFsctl for snapshot list FSCTL_GET_SHADOW_COPY_DATA is a FSCTL, so set the isFsctl marker otherwise smbclient allinfo will not report snapshots any more with the changes made for Bug #8311 Autobuild-User(master): Christian Ambach Autobuild-Date(master): Thu Aug 30 18:57:24 CEST 2012 on sn-devel-104 --- source3/libsmb/clifile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c index 64e4984..6763d69 100644 --- a/source3/libsmb/clifile.c +++ b/source3/libsmb/clifile.c @@ -5256,7 +5256,7 @@ struct tevent_req *cli_shadow_copy_data_send(TALLOC_CTX *mem_ctx, SIVAL(state->setup + 0, 0, FSCTL_GET_SHADOW_COPY_DATA); SSVAL(state->setup + 2, 0, fnum); - SCVAL(state->setup + 3, 0, 0); /* isFsctl */ + SCVAL(state->setup + 3, 0, 1); /* isFsctl */ SCVAL(state->setup + 3, 1, 0); /* compfilter, isFlags (WSSP) */ subreq = cli_trans_send( -- 1.7.11.4 From 7e0c40f5c1b26fb1151ea7c3c3049c0997fc29a9 Mon Sep 17 00:00:00 2001 From: Christian Ambach Date: Wed, 5 Sep 2012 15:07:54 +0200 Subject: [PATCH 2/2] s3:client use more access bits for snapshot display otherwise Windows server will reject the request for shadow copy enumeration with access denied --- source3/client/client.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/client/client.c b/source3/client/client.c index 05c4f91..58115ad 100644 --- a/source3/client/client.c +++ b/source3/client/client.c @@ -1717,7 +1717,8 @@ static int do_allinfo(const char *name) } status = cli_ntcreate(cli, name, 0, - CREATE_ACCESS_READ, 0, + SEC_FILE_READ_DATA | SEC_FILE_READ_ATTRIBUTE | + SEC_STD_SYNCHRONIZE, 0, FILE_SHARE_READ|FILE_SHARE_WRITE |FILE_SHARE_DELETE, FILE_OPEN, 0x0, 0x0, &fnum); -- 1.7.11.4