From ffab1d7cb28590f8e1ee9b90a8f7dbb84e7adb07 Mon Sep 17 00:00:00 2001 From: Matthieu Patou Date: Mon, 1 Oct 2012 21:36:34 -0700 Subject: [PATCH 19/20] s4-dns: Ignore zones that shouldn't be returned currently RootDNSServers should never be returned (Windows DNS server don't) ..TrustAnchors should never be returned as is, (Windows returns TrustAnchors) and for the moment we don't support DNSSEC so we'd better not return this zone. --- source4/dns_server/dns_server.c | 14 +++++++++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/source4/dns_server/dns_server.c b/source4/dns_server/dns_server.c index 003dd4e..e750e33 100644 --- a/source4/dns_server/dns_server.c +++ b/source4/dns_server/dns_server.c @@ -833,7 +833,13 @@ static void dns_task_init(struct task_server *task) z->name = ldb_msg_find_attr_as_string(res->msgs[i], "name", NULL); z->dn = talloc_move(z, &res->msgs[i]->dn); - + /* + * Ignore the RootDNSServers zone and zones that we don't support yet + * RootDNSServers should never be returned (Windows DNS server don't) + * ..TrustAnchors should never be returned as is, (Windows returns + * TrustAnchors) and for the moment we don't support DNSSEC so we'd better + * not return this zone. + */ + if ((strcmp(z->name, "RootDNSServers") == 0) || + (strcmp(z->name, "..TrustAnchors") == 0)) { + DEBUG(10, ("Ignoring zone %s\n", z->name)); + talloc_free(z); + continue; + } DLIST_ADD_END(dns->zones, z, NULL); } -- 1.7.9.5