From 47215999a3b189244bd0edd0ba39f789237aa04b Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 24 Oct 2012 11:56:02 +1100 Subject: [PATCH] dsdb-cracknames: Always use talloc_zero() Otherwise, we will return un-initialised values to the caller, which will attempt to push them onto the wire. Found by Greg Dickie . Andrew Bartlett --- source4/dsdb/samdb/cracknames.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c index c366019..6ad8026 100644 --- a/source4/dsdb/samdb/cracknames.c +++ b/source4/dsdb/samdb/cracknames.c @@ -1472,7 +1472,7 @@ WERROR dcesrv_drsuapi_CrackNamesByNameFormat(struct ldb_context *sam_ctx, TALLOC uint32_t i, count; WERROR status; - *ctr1 = talloc(mem_ctx, struct drsuapi_DsNameCtr1); + *ctr1 = talloc_zero(mem_ctx, struct drsuapi_DsNameCtr1); W_ERROR_HAVE_NO_MEMORY(*ctr1); count = req1->count; -- 1.7.11.7