From 3d29bb2d37b02909ecb500e864f3c13e06957a86 Mon Sep 17 00:00:00 2001 From: Christian Ambach Date: Wed, 20 Feb 2013 16:59:05 +0100 Subject: [PATCH] s3:rpc_client fix a crash state->cli->dc does not have to be set (e.g. when running net rpc join against an older Samba PDC), so check it before dereferencing it This fixes Bug 9669 - net rpc join crashes against a Samba 3.0.33 PDC Bug: https://bugzilla.samba.org/show_bug.cgi?id=9669 Signed-off-by: Christian Ambach Reviewed-by: Andreas Schneider Autobuild-User(master): Christian Ambach Autobuild-Date(master): Wed Feb 20 19:00:52 CET 2013 on sn-devel-104 --- source3/rpc_client/cli_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c index 2743a07..2e978ef 100644 --- a/source3/rpc_client/cli_pipe.c +++ b/source3/rpc_client/cli_pipe.c @@ -1805,7 +1805,7 @@ static void rpc_pipe_bind_step_two_done(struct tevent_req *subreq) status = dcerpc_netr_LogonGetCapabilities_r_recv(subreq, talloc_tos()); TALLOC_FREE(subreq); if (NT_STATUS_EQUAL(status, NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE)) { - if (state->cli->dc->negotiate_flags & + if (state->cli->dc && state->cli->dc->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) { DEBUG(5, ("AES is not supported and the error was %s\n", nt_errstr(status))); -- 1.8.1.3