From 784a2820bac5cb6d090d87b1737f7cc79723950b Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 3 Apr 2013 15:46:00 +0200 Subject: [PATCH] BUG 9699: Fix adding case sensitive spn. We should be able to define the case of the spn cause it is important for some services like nfs. 'net ads keytab add "nfs"' should not result in an uppercase spn. Signed-off-by: Andreas Schneider --- source3/libads/ldap.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c index ca5962c..2a4a83b 100644 --- a/source3/libads/ldap.c +++ b/source3/libads/ldap.c @@ -1949,12 +1949,7 @@ ADS_STATUS ads_add_service_principal_name(ADS_STRUCT *ads, const char *machine_n ads_msgfree(ads, res); return ADS_ERROR(LDAP_NO_MEMORY); } - if (!strupper_m(psp1)) { - ret = ADS_ERROR(LDAP_NO_MEMORY); - goto out; - } - - if (!strlower_m(&psp1[strlen(spn)])) { + if (!strlower_m(&psp1[strlen(spn) + 1])) { ret = ADS_ERROR(LDAP_NO_MEMORY); goto out; } @@ -1970,12 +1965,7 @@ ADS_STATUS ads_add_service_principal_name(ADS_STRUCT *ads, const char *machine_n ret = ADS_ERROR(LDAP_NO_MEMORY); goto out; } - if (!strupper_m(psp2)) { - ret = ADS_ERROR(LDAP_NO_MEMORY); - goto out; - } - - if (!strlower_m(&psp2[strlen(spn)])) { + if (!strlower_m(&psp2[strlen(spn) + 1])) { ret = ADS_ERROR(LDAP_NO_MEMORY); goto out; } -- 1.8.2