From d16da444a3db1e93d31dff6862dae15a563db016 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 4 Sep 2013 13:57:00 +0200 Subject: [PATCH] smbd: Fix an ancient oplock bug If we get an oplock break response, we forgot to remove the oplock break timeout. Found by stopping raw.oplock.exclusive5 after the 2nd open and watching a debug level 10 log. This amends 08a9de89 from 2007. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison (cherry picked from commit 0670975261c5f29394f9e9d25f899a7de948dad1) --- source3/smbd/oplock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c index 05b0d0b..f2d39b8 100644 --- a/source3/smbd/oplock.c +++ b/source3/smbd/oplock.c @@ -150,6 +150,8 @@ static void downgrade_file_oplock(files_struct *fsp) sconn->oplocks.exclusive_open--; sconn->oplocks.level_II_open++; fsp->sent_oplock_break = NO_BREAK_SENT; + + TALLOC_FREE(fsp->oplock_timeout); } /**************************************************************************** -- 1.7.9.5